Jcn 469 implement state event parameter #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,6 +83,9 @@ module.exports = class Dispatcher { | |||
|
|
|||
| if(typeof taskToken !== 'undefined' && typeof taskToken !== 'string') | |||
| throw new LambdaError('Task token must be a string if present', LambdaError.codes.INVALID_TASK_TOKEN); | |||
|
|
|||
| if(typeof state !== 'undefined' && typeof state !== 'object') | |||
There was a problem hiding this comment.
Que onda si llega null? te lo va a tomar como objeto 👀
gastonpereyra
approved these changes
Jan 30, 2024
jormaechea
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link al ticket
Historia
Subtarea
Descripción del requerimiento
Se modificó el package sls-helper-plugin-janis para que llegue un nuevo dato en el evento de las lambdas de las tasks de las state-machines(https://janiscommerce.atlassian.net/browse/JCN-466)
La property nueva es
statey esta debe ser accesible por la lambda de la task que la utiliza.Esto específicamente para saber si una ejecución es un retry o para saber que numero de retry es la ejecución actual.
Descripción de la solución
Se modificaron algunas clases donde se van pasando los datos de los eventos a los lambdas haciéndole llegar el nuevo dato de
statey se agregaron nuevos métodos setearlos y getearlo desde la lambda.Changelog