Fix endless loop for error case (#63) #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the temporary file created by OCR was not found, that error was reported endlessly because the status was never reset. Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
You're right with your observation, but I would recommend to set the status to FAILED instead of deleting the status completely. This gives the user more track to the errors, that happened. $status->setStatus('FAILED');
$this->statusMapper->update($status);also a error log statement could be added. Next weeks I plan to enhance this. Maybe there will be the possibility to see the error cause in the personal settings section as well then. |
|
That sounds good. Then this pull request can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the temporary file created by OCR was not found, that error was
reported endlessly because the status was never reset.
Signed-off-by: Stefan Weil sw@weilnetz.de