Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: default to Group.command_class and Group.group_class when creating subcommands #162

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix: default to Group.command_class and Group.group_class when creating subcommands #162

merged 1 commit into from
Jul 13, 2023

Conversation

janluke
Copy link
Owner

@janluke janluke commented Jul 13, 2023

@janluke janluke added the bug Something isn't working label Jul 13, 2023
@janluke janluke merged commit 56049d5 into master Jul 13, 2023
@janluke janluke deleted the fix/group_command_and_group_class branch July 13, 2023 18:06
kdeldycke added a commit to kdeldycke/click-extra that referenced this pull request Jul 14, 2023
@kdeldycke
Removes cloup workaround.
f976eeb 
Refs:
janluke/cloup#160
janluke/cloup#162
@kdeldycke
Copy link
Contributor

I can confirm this fixes #160. Thanks @janluke for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloup.Group ignores command_class to produce sub-commands
2 participants
@janluke @kdeldycke