Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crop.json #118

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Update crop.json #118

merged 4 commits into from
Jul 10, 2023

Conversation

CaelynCheung1996
Copy link
Contributor

This video only have 164 frames. Nonetype error occurs when using 165.0

This video only have 164 frames. Nonetype error occurs when using 165.0
This need to be changed since the Butterfly dataset gallery is updated.
Direct import from pocovidnet does not work
Copy link
Owner

@jannisborn jannisborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CaelynCheung1996,

Thanks for the suggestion, I'm happy to approve the PR once we revert the change about sys.path (see my comment)

@@ -1,3 +1,5 @@
import sys
sys.path.append('../pocovidnet/')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working with sys.path.append is bad styling as it violates PEP conventions

@jannisborn jannisborn linked an issue Jul 10, 2023 that may be closed by this pull request
@jannisborn jannisborn merged commit 90a2018 into jannisborn:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_and_process_web_data.sh deprecated and cropping problems
2 participants