Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference error in onStrokeEnd usage #2379

Closed
jasonjgardner opened this issue Jun 12, 2024 · 0 comments
Closed

Reference error in onStrokeEnd usage #2379

jasonjgardner opened this issue Jun 12, 2024 · 0 comments
Labels
bug An issue, where the program does not do what it is supposed to

Comments

@jasonjgardner
Copy link

What are you trying to do, and what do you expect to happen?

Attempting to use onStrokeEnd() in my plugin's brush tool. I expect the method to be called after ending a brush stroke when the plugin's brush tool is selected.

What happens instead?

The BrushOptions.onStrokeEnd method is not called on selected brush tools. In Painter.stopPaintTool, a ReferenceError is thrown at painter.js:267 because the variables x, y, uv, event, and data are not in the current scope.

ReferenceError

Model format in which the issue occurs

Any format

Blockbench variant

Program

Blockbench version

4.10.3

Operating System

Windows 11

Installed Blockbench plugins

PBR Preview

@JannisX11 JannisX11 added the bug An issue, where the program does not do what it is supposed to label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue, where the program does not do what it is supposed to
Projects
None yet
Development

No branches or pull requests

2 participants