Rename prop duplicateFunc() to key()
#238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cates=true to cover different key functions
janosh
changed the title
duplicateFunc() to equal()duplicateFunc() to key()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234.
Add prop
key: (opt: T) => unknown = (opt) => `${get_label(opt)}`.toLowerCase()which should map options to a value by which equality of options is determined. Used inadd(option)/remove(option)functions, which previously had hacky hard-coded equality checks.keyreplacesduplicateFuncwhich served a similar purpose but with a worse API. It also wasn't used inadd(option)/remove(option)even though arguably it should have been.This is a breaking change and will be released as v10.