Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show createOptionMsg if allowUserOptions is truthy and user entered text #254

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Always show createOptionMsg if allowUserOptions is truthy and user entered text #254

merged 5 commits into from
Jul 18, 2023

Conversation

janosh
Copy link
Owner

@janosh janosh commented Jul 18, 2023

Closes #253.

@janosh janosh added UX User experience fix Bug fix PRs labels Jul 18, 2023
@janosh janosh temporarily deployed to github-pages July 18, 2023 04:06 — with GitHub Actions Inactive
@janosh
Copy link
Owner Author

janosh commented Jul 18, 2023

@paul-brenner I think this fixes your issue. The docs show the new behavior. Let me know if that works for you.

@paul-brenner
Copy link

Looks good!

@janosh janosh temporarily deployed to github-pages July 18, 2023 15:52 — with GitHub Actions Inactive
@janosh janosh merged commit 01c852a into main Jul 18, 2023
@janosh janosh deleted the fix-gh-253 branch July 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Bug fix PRs UX User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When allowUserOptions={true} user can't enter custom option if it is a substring of an existing option
2 participants
@janosh @paul-brenner