Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When opening ToC on mobile, ensure active ToC item is scrolled into view #54

Merged
merged 11 commits into from
Mar 1, 2024
Merged

When opening ToC on mobile, ensure active ToC item is scrolled into view #54

merged 11 commits into from
Mar 1, 2024

Conversation

Comefled
Copy link
Contributor

Could also be made an option if you don't want to change the current behavior.

Comefled and others added 11 commits February 29, 2024 18:34
@Comefled
When opening mobile view, scroll to the active item
d780777
@Comefled
Return early if nav element isn't available
0641821
@janosh
update dependencies
0ee50b5
@janosh
DemoNav remove falsely copy-pasted console.error
b03f273
@janosh
'subheadings are indented' simplify test DOM
4e373bf
@janosh
reset windowWidth in between unit tests
a989196 
prevents side-effect leakage
@janosh
emit 'open' events whenever open prop changes
4278cc3 
add test for custom open event
@janosh
test toggling open state when clicking ToC menu button
a67f551
@janosh
change condition class:active={activeTocLi === tocItems[idx]}
d295de3 
was class:active={activeHeading === heading}
also rename handler->li_click_key_handler
@janosh
ensure active ToC is in view when ToC opens on mobile
837f588
@janosh
test `active heading is in into view and highlighted when opening ToC…
c7f5b93 
… on mobile`
@janosh janosh changed the title When opening mobile view, scroll to the active item When opening ToC on mobile, ensure active ToC item is scrolled into view Mar 1, 2024
janosh
janosh approved these changes Mar 1, 2024
View reviewed changes
Copy link
Owner

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks great suggestion! happy to change the default behavior to this

@janosh janosh merged commit 34b92a0 into janosh:main Mar 1, 2024
4 checks passed
@Comefled
Copy link
Contributor Author

@janosh Could you release this as a new version, so my website can benefit from it?

@janosh janosh added enhancement New feature or request mobile Issues specific to mobile screens testing Test all the things labels Mar 21, 2024
@janosh
Copy link
Owner

janosh commented Mar 21, 2024

v0.5.8 is now on NPM

@Comefled
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request mobile Issues specific to mobile screens testing Test all the things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Comefled @janosh