Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/51 #58

Merged
merged 8 commits into from
May 7, 2017
Merged

Issues/51 #58

merged 8 commits into from
May 7, 2017

Conversation

jantman
Copy link
Owner

@jantman jantman commented May 7, 2017

IMPORTANT: Please take note of the below checklist, especially the first two items.

Pull Request Checklist

  • All pull requests must include the Contributor License Agreement (see below).
  • Code should conform to the following:
    • pep8 compliant with some exceptions (see pytest.ini)
    • 100% test coverage with pytest (with valid tests). If you have difficulty
      writing tests for the code, feel free to ask for help or submit the PR without tests.
    • Complete, correctly-formatted documentation for all classes, functions and methods.
    • documentation has been rebuilt with tox -e docs
    • All modules should have (and use) module-level loggers.
    • Commit messages should be meaningful, and reference the Issue number
      if you're working on a GitHub issue (i.e. "issue #x - "). Please
      refrain from using the "fixes #x" notation unless you are sure that the
      the issue is fixed in that commit.
    • Git history is fully intact; please do not squash or rewrite history.

Contributor License Agreement

By submitting this work for inclusion in biweeklybudget, I agree to the following terms:

  • The contribution included in this request (and any subsequent revisions or versions of it)
    is being made under the same license as the biweeklybudget project (the Affero GPL v3,
    or any subsequent version of that license if adopted by biweeklybudget).
  • My contribution may perpetually be included in and distributed with biweeklybudget; submitting
    this pull request grants a perpetual, global, unlimited license for it to be used and distributed
    under the terms of biweeklybudget's license.
  • I have the legal power and rights to agree to these terms.

@codecov-io
Copy link

codecov-io commented May 7, 2017

Codecov Report

Merging #58 into master will decrease coverage by 0.43%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   42.63%   42.19%   -0.44%     
==========================================
  Files          43       44       +1     
  Lines        2029     2050      +21     
  Branches      293      295       +2     
==========================================
  Hits          865      865              
- Misses       1140     1161      +21     
  Partials       24       24
Impacted Files Coverage Δ
biweeklybudget/initdb.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767e98b...01a9d01. Read the comment docs.

@jantman jantman merged commit 727bef5 into master May 7, 2017
@jantman jantman deleted the issues/51 branch May 7, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants