Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-2065: [QE] Automate Scenario - Telemetry #1268

Merged
merged 11 commits into from
Jun 6, 2024

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented May 21, 2024

Description

Add tests that verify analytics-provider-segment is enabled by default and that it can be disabled by configuration.
One test is disabled until #1266 gets resolved - this test relies on RBAC test execution, which is currently not happening.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • E2E Tests are updated and passing

How to test changes / Special notes to the reviewer

I initially tried to use API to test the state of the plugin. This works with only for non-RBAC tests. For RBAC, I wasn't able to acquire the token that is needed to access the API. So in RBAC, the plugin is tested using UI. The speed of the tests differ significantly - 1 sec vs 30 sec.

Test in RBAC UI

40d725992904d6feb7fc362ef7ef05803f4d1648.mp4

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

2 similar comments
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

8 similar comments
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

@zdrapela zdrapela changed the title [WIP] RHIDP-2065: [QE] Automate Scenario - Telemetry RHIDP-2065: [QE] Automate Scenario - Telemetry May 23, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

5 similar comments
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

@albarbaro
Copy link
Contributor

/retest

Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

1 similar comment
Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

@zdrapela
Copy link
Member Author

zdrapela commented Jun 4, 2024

/test e2e-tests

@zdrapela zdrapela changed the title [WIP] RHIDP-2065: [QE] Automate Scenario - Telemetry RHIDP-2065: [QE] Automate Scenario - Telemetry Jun 4, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@subhashkhileri
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1268!

@openshift-merge-bot openshift-merge-bot bot merged commit 9fd07aa into janus-idp:main Jun 6, 2024
8 checks passed
@zdrapela
Copy link
Member Author

zdrapela commented Jun 6, 2024

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@zdrapela: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zdrapela
Copy link
Member Author

zdrapela commented Jun 6, 2024

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@zdrapela: new pull request created: #1305

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants