Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDH pre-submit and post-submit job for 1.2.x #1311

Conversation

subhashkhileri
Copy link
Member

@subhashkhileri subhashkhileri commented Jun 10, 2024

Description

RHDH pre-submit and post-submit job for 1.2.x

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-2049

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1311!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1311!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1311!

@subhashkhileri
Copy link
Member Author

/test e2e-tests

@subhashkhileri subhashkhileri changed the title [WIP] RHDH pre-submit and post-submit job for 1.2.x RHDH pre-submit and post-submit job for 1.2.x Jun 10, 2024
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1311!

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1311!

@openshift-merge-bot openshift-merge-bot bot merged commit 5caa0a0 into janus-idp:main Jun 10, 2024
8 checks passed
@subhashkhileri
Copy link
Member Author

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@subhashkhileri: new pull request created: #1314

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants