Filter by group title also executes "root" tests

[Julien-R44]

Description

Hey !

I just noticed that when filtering by a group name, tests that are not in a group are also executed.

Exemple :

import { test } from '@japa/runner'

test.group('Maths.add', () => {
  test('hey', ({ assert }) => assert.isTrue(true))
})

test('root', () => console.log('Hey'))

When executing npm run test --groups Maths.add, the test root is also executed

Is this the desired behavior? It seems a bit weird to me, and I don't see anything related to it in the documentation
( By the way it would be awesome if we could have an Algolia search 😋 )

Package version

@japa/runner 2.0.8

---

If you confirm that this is not the desired behavior, I can take care of it and suggest a PR 👍

[thetutlage]

Is it not working with standalone Japa or was related to this adonisjs/assembler#51?

[Julien-R44]

Yep, it's not related to this PR
I have the same behavior with standalone Japa

[thetutlage]

Ohh. I just noticed one thing. The command should be

npm run test -- --groups Maths.add

The additional -- forwards the flags to the underlying command. Otherwise the flags are meant for the npm cli.

[Julien-R44]

Oh yes sorry, I know that. I just made a mistake: I use pnpm, and pnpm forwards the arguments well this way ( no need for -- )

I'll give you another example to make it clearer:

import { test } from '@japa/runner'

test.group('GroupOne', (group) => {
  test('My Test', ({ assert }) => {
    assert.isTrue(true)
  })
})

test.group('GroupTwo', (group) => {
  test('My Test', ({ assert }) => {
    assert.isTrue(true)
  })
})

test('Root', () => console.log('hey'))

npx ts-node test/index.ts --groups "GroupOne" executes "My test" and "Root" tests. So the "GroupTwo" is ignored, but not the "root" test that is not inside a group

[thetutlage]

Cool. Just wanted to make sure before giving it a go