Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Length Enforcement #185

Closed
acouch00 opened this issue Nov 27, 2013 · 14 comments
Closed

Password Length Enforcement #185

acouch00 opened this issue Nov 27, 2013 · 14 comments

Comments

@acouch00
Copy link
Collaborator

I remember reading this post, where I was given to believe that there would be some sort of enforcement on the password length.

Did this end up getting pushed or kicked?

@japacible
Copy link
Owner

What happened to this?

@japacible
Copy link
Owner

Where is the most appropriate place to add a length check, say 6char?

@jbrodhacker @kcorman ?

@jbrodhacker
Copy link
Collaborator

Model for user up with all the other validates statements

@japacible
Copy link
Owner

Thanks, added in 70dcd88

@ghost ghost assigned japacible Dec 7, 2013
@acouch00 acouch00 mentioned this issue Dec 7, 2013
@japacible
Copy link
Owner

Lovely broke login in #236 by adding this in.

It's commented out under app/model/user.rb.

@japacible japacible reopened this Dec 7, 2013
@jbrodhacker
Copy link
Collaborator

If you use the solution I committed and linked to in #236, it unbreaks log in for the already current users and should provide validation for new users and for changing the password :) I say should because I didn't test the validation to ensure that it still validates =P

@japacible
Copy link
Owner

Oops, totally missed your commit. Thanks! I'll test it in master.

@jbrodhacker
Copy link
Collaborator

Of course :)

@japacible
Copy link
Owner

Hmm, it's currently not working for the edit/settings page, but works for log in/sign up.

@jbrodhacker
Copy link
Collaborator

Try using the syntax
:on => [:create, :edit]
instead of
:on => :create, :on => :edit

@jbrodhacker
Copy link
Collaborator

Also, if that doesn't work, trying :update instead of :edit

@japacible
Copy link
Owner

:update did the trick! 10a49bb

@japacible
Copy link
Owner

@jbrodhacker can you do a quick edit in wip-commissions and close the issue?

@jbrodhacker
Copy link
Collaborator

Done 6f39f68 and done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants