-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password Length Enforcement #185
Comments
What happened to this? |
Where is the most appropriate place to add a length check, say 6char? |
Model for user up with all the other validates statements |
Thanks, added in 70dcd88 |
Lovely broke login in #236 by adding this in. It's commented out under app/model/user.rb. |
If you use the solution I committed and linked to in #236, it unbreaks log in for the already current users and should provide validation for new users and for changing the password :) I say should because I didn't test the validation to ensure that it still validates =P |
Oops, totally missed your commit. Thanks! I'll test it in master. |
Of course :) |
Hmm, it's currently not working for the edit/settings page, but works for log in/sign up. |
Try using the syntax |
Also, if that doesn't work, trying :update instead of :edit |
:update did the trick! 10a49bb |
@jbrodhacker can you do a quick edit in wip-commissions and close the issue? |
Done 6f39f68 and done :) |
I remember reading this post, where I was given to believe that there would be some sort of enforcement on the password length.
Did this end up getting pushed or kicked?
The text was updated successfully, but these errors were encountered: