lower MSRV to 1.31 and test it in CI #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it explicit that MSRV does not cover `cargo test`-ing this crate remove unidiomatic edition 2015 syntax from API documentation
|
As a consumer I am more interested in knowing which version of Rust the test suite has been verified to pass in, but also I admit I seem to have different priorities w.r.t. MSRV than you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it explicit that MSRV does not cover
cargo test-ing this crateremove unidiomatic edition 2015 syntax from API documentation
We can lower the MSRV if we only claim that the crate can be built with the specified version. When used as a dependency, the dev-dependencies (like
quickcheck) won't be built so that ought to be fine (casthas nodependencies, onlydev-dependencies).Also, I'd like to not make the MSRV depend on third party crates because they (or their recursive dependencies) may change their actual (which is not the same as documented) MSRV at any time.
cc @briansmith