Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider reexporting core::ffi::c_void #10

Closed
SimonSapin opened this issue Nov 4, 2018 · 1 comment
Closed

Consider reexporting core::ffi::c_void #10

SimonSapin opened this issue Nov 4, 2018 · 1 comment

Comments

@SimonSapin
Copy link

Similar to rust-lang/libc#1082 / https://github.com/rust-lang/rfcs/blob/master/text/2521-c_void-reunification.md, for the same reasons.
@jeikabu jeikabu mentioned this issue Jan 29, 2019
Merged
bors bot added a commit that referenced this issue Feb 5, 2019
@bors @jeikabu
Merge #11
62eec1b 
11: Re-export core::ffi::c_void r=japaric a=jeikabu

#10

Without this trying to use bindgen like:
```rust
let bindings = bindgen::Builder::default()
        .header("wrapper.h")
        .ctypes_prefix("cty")
        .use_core()
        .generate();
```

Results in lots of:
```
error[E0308]: mismatched types
  --> runng/src/protocol/mod.rs:49:43
   |
49 |         let res = nng_setopt(socket, opt, topic_ptr, topic_size);
   |                                           ^^^^^^^^^ expected enum `cty::c_void`, found enum `std::ffi::c_void`
   |
   = note: expected type `*const cty::c_void`
              found type `*const std::ffi::c_void`
```


Co-authored-by: jake <jeikabu@gmail.com>
bors bot added a commit that referenced this issue Feb 5, 2019
@bors @jeikabu
Merge #11
b613a06 
11: Re-export core::ffi::c_void r=japaric a=jeikabu

#10

Without this trying to use bindgen like:
```rust
let bindings = bindgen::Builder::default()
        .header("wrapper.h")
        .ctypes_prefix("cty")
        .use_core()
        .generate();
```

Results in lots of:
```
error[E0308]: mismatched types
  --> runng/src/protocol/mod.rs:49:43
   |
49 |         let res = nng_setopt(socket, opt, topic_ptr, topic_size);
   |                                           ^^^^^^^^^ expected enum `cty::c_void`, found enum `std::ffi::c_void`
   |
   = note: expected type `*const cty::c_void`
              found type `*const std::ffi::c_void`
```


Co-authored-by: jake <jeikabu@gmail.com>
@japaric
Copy link
Owner

japaric commented Feb 8, 2019

Done in #11 and available in v0.2.0

@japaric japaric closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @japaric