Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify --> ==> ~~>, remove IO, add Callback #145

Closed
japgolly opened this issue Jun 15, 2015 · 3 comments
Closed

Unify --> ==> ~~>, remove IO, add Callback #145

japgolly opened this issue Jun 15, 2015 · 3 comments

Comments

@japgolly
Copy link
Owner

The attempt to satisfy everyone by supporting unsafe callbacks (? => Unit) and using Scalaz's IO has created a division and incompatibility between code. Very bad for community. Already seeing small spots of pain with shared libraries & components.

We need to just have one, single, common way.

The solution:

  • A simple, lightweight built-in Callback type. All callbacks are wrapped in it - simple.
  • We have 1 operator instead of 3.

Will probably do this earlier rather than later. The longer we wait the worse the change is going to be.
Migration is doing to be a day of pain for everyone, but a worthy one-time price to pay for a lifetime of happiness when everyone's libraries & shared components are compatible.

I'm even considering a quick 0.10.0 to get this over and done with before React 0.14 comes out.

@ngbinh
Copy link

ngbinh commented Jun 15, 2015

💯 had to come back and replace all of our unsafePerformIO with IO version.

@japgolly
Copy link
Owner Author

At the same time, should probably also remove variance from React type ctors. It's causing such a frustrating headache having to pepper every new addition to extra with special helper methods to deal with type inference problems.

@japgolly
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants