-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify --> ==> ~~>, remove IO, add Callback #145
Comments
ghost
mentioned this issue
Jun 15, 2015
💯 had to come back and replace all of our |
At the same time, should probably also remove variance from React type ctors. It's causing such a frustrating headache having to pepper every new addition to extra with special helper methods to deal with type inference problems. |
japgolly
added a commit
that referenced
this issue
Aug 18, 2015
japgolly
added a commit
that referenced
this issue
Aug 19, 2015
japgolly
added a commit
that referenced
this issue
Aug 19, 2015
japgolly
added a commit
that referenced
this issue
Aug 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The attempt to satisfy everyone by supporting unsafe callbacks (? => Unit) and using Scalaz's
IO
has created a division and incompatibility between code. Very bad for community. Already seeing small spots of pain with shared libraries & components.We need to just have one, single, common way.
The solution:
Callback
type. All callbacks are wrapped in it - simple.Will probably do this earlier rather than later. The longer we wait the worse the change is going to be.
Migration is doing to be a day of pain for everyone, but a worthy one-time price to pay for a lifetime of happiness when everyone's libraries & shared components are compatible.
I'm even considering a quick 0.10.0 to get this over and done with before React 0.14 comes out.
The text was updated successfully, but these errors were encountered: