Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset scroll position to top after route transition #57

Closed
chandu0101 opened this issue Dec 26, 2014 · 3 comments
Closed

reset scroll position to top after route transition #57

chandu0101 opened this issue Dec 26, 2014 · 3 comments
Milestone
0.7.0

Comments

@chandu0101
Copy link
Contributor 

 From #29 japgolly  : 
About scrollTo, do other routers do that on every route change? 
Also could you please open a new issue if you want to discuss that further? Cheers

Other routers (atleast react-router) resetting scroll position to top for each route transition by default , but they have an option(ignoreScrol...) to override that .. .
@japgolly japgolly added this to the 0.7.0 milestone Dec 26, 2014
japgolly added a commit that referenced this issue Dec 28, 2014
@japgolly
Router scrolls to top (by default) on route change
cc2dc6a 
see #57
japgolly added a commit that referenced this issue Dec 28, 2014
@japgolly
Router scrolls to top (by default) on route change
82415b5 
see #57
@japgolly
Copy link
Owner

Done in 82415b5.

@chandu0101 Can you confirm this is good?

@chandu0101
Copy link
Contributor Author

looks good mate .
Thank You

@japgolly
Copy link
Owner

Sweet, thanks mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@japgolly @chandu0101