Sync workalendar 14.1.0 #16
Conversation
closes workalendar#454 It fixes two things: * Family Day was introduced in 2013, workalendar was assuming it was there before * In 2019, Family Day was moved from the 2nd to the 3rd MON of February
…a-family-day Fix Family Day computation for British Columbia (Canada)
refs workalendar#451 * Fix Robert E. Lee's Birthday label rules (renamed as of year 2016 into the neutral "State Holiday") * (hopefully) Fixed Washington's Birthday observance around Christmas time * Fix Confederate Memorial Day label rules (renamed as of year 2016 into the neutral "State Holiday")
…ixes Fix Georgia miscalculation of several state holidays
Fixing the Israel holidays
also, updated Changelog.md
Expanding @fredrike's idea, I've changed the way this warning message was generated. Several reasons: * Depending on your Python version, the message was sometimes a bit awkward, with years being in disorder (e.g.: "year 2019, 2020, 2018"). Dictionaries are strange. * If we plan for the future, it wouldn't have been readable to have warnings with "2018, 2019, 2020, 2021, 2022, 2023, etc". An interval is more future-proof. * Added tests, because tests are great ;o) refs workalendar#459
China support years as a dynamic warning
- Added Israel holidays eves and removed holidays which are not affecting the working days in Israel (workalendar#461). - Fix warning in China's holidays to dynamically read supported years, thx @fredrike (workalendar#459).
Adding holidays for Belarus
It is really useful to allow reuse of this class.
…ar-refactor Refactor BrazilBankCalendar to use `include_*` flags
Change: - Added BrazilBankCalendar to support `include_` flags and make it possible to extend and change these flags to support custom bank calendars (workalendar#474).
This holiday was shifted to March 31st because of the coronavirus crisis refs workalendar#476
…ay-names-shift-2020 Fix argentina holiday names shift 2020
|
@jaraco Hi, if you don't have time to look at this, would you perhaps be prepared to make me a contributor and able to make releases? |
I suspect this issue doesn't affect #15. I see there's already a test for 2020-12-28 as an observed holiday, so I'll follow up in that ticket. Still, I think we want to do this work to fix #17.
Thanks for the ping. I don't subscribe to my own repos (too much noise, so I need to batch my work), but thanks for the mention to remind me (otherwise could have been months ;). |
Most definitely. Your help on this project has been immeasurably helpful. I even tried making this merge recently and gave up before completing it. Let's work through this PR together and after, I'll grant access to help maintain the project and guide on cutting a release. |
|
It looks like the tests are failing on Windows, all the ones about ical export. |
|
I just had a thought about the series stuff. The implicit assumption is
that if one of the days is shifted then the days after it should be shifted
too (otherwise the original shift was meaningless).
However, in each case I recall, the original shift is based on a country
level observance rule (usually involving skipping Sunday I think). If that
original shift was incorrect, then clearly applying the series shifts would
also be incorrect.
Is it possible that any of the original country shifts was not right for
the holidays involved?
…On Mon, 4 Jan 2021, 00:37 Jason R. Coombs, ***@***.***> wrote:
Merged #16 <#16> into main.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFHWKJTGRSYG7FEC7G6TY3SYEETVANCNFSM4VGEOM4Q>
.
|
Resolves #17. All tests clean for v14.1.0, please consider merging and releasing.