Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(use-scroller): unsubscribe from updates when hook has unmounted #97

Merged
merged 2 commits into from
Oct 23, 2021
Merged

fix(use-scroller): unsubscribe from updates when hook has unmounted #97

merged 2 commits into from
Oct 23, 2021

Conversation

jaredLunde
Copy link
Owner

  • Remove travis in favor of GitHub Actions
  • Use @swc-node/jest as a jest transformer
  • Use pnpm instead of yarn
  • Use semantic-release for automated releases
  • Use default prettier config

@codecov-commenter
Copy link

Codecov Report

Merging #97 (b2aebaf) into master (668e2a4) will increase coverage by 0.35%.
The diff coverage is 95.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   94.18%   94.54%   +0.35%     
==========================================
  Files          13       13              
  Lines         499      605     +106     
  Branches      134      175      +41     
==========================================
+ Hits          470      572     +102     
- Misses         25       30       +5     
+ Partials        4        3       -1
Impacted Files Coverage Δ
src/use-scroll-to-index.ts 75.92% <74.28%> (+0.37%) ⬆️
src/use-infinite-loader.ts 90.00% <85.71%> (+2.50%) ⬆️
src/masonry.tsx 88.88% <88.23%> (+1.38%) ⬆️
src/use-positioner.ts 92.15% <94.91%> (+0.11%) ⬆️
src/interval-tree.ts 98.31% <97.76%> (+0.20%) ⬆️
src/elements-cache.ts 100.00% <100.00%> (ø)
src/list.tsx 100.00% <100.00%> (ø)
src/masonry-scroller.tsx 100.00% <100.00%> (ø)
src/use-container-position.ts 94.73% <100.00%> (+1.40%) ⬆️
src/use-force-update.ts 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df073ac...b2aebaf. Read the comment docs.

@jaredLunde jaredLunde merged commit 2117625 into master Oct 23, 2021
@jaredLunde jaredLunde deleted the use-pnpm-and-github-actions branch October 23, 2021 15:58
github-actions bot pushed a commit that referenced this pull request Oct 23, 2021
@semantic-release-bot
chore(release): 3.6.1
b8eae68 
## [3.6.1](v3.6.0...v3.6.1) (2021-10-23)

### Bug Fixes

* **use-scroller:** unsubscribe from updates when hook has unmounted ([#97](#97)) ([2117625](2117625))
@github-actions
Copy link

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredLunde @codecov-commenter