Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please depend on image with default-features = false #4

Closed
pchickey opened this issue Apr 23, 2021 · 1 comment · Fixed by #5
Closed

Please depend on image with default-features = false #4

pchickey opened this issue Apr 23, 2021 · 1 comment · Fixed by #5
Assignees
@pchickey
Labels
enhancement New feature or request

Comments

@pchickey
Copy link
Contributor

Hi! Thanks for this crate.

I'm trying to use webp alongside other parts of the image crate, but I need to set features of the image crate (particularly, disabling rayon because I am compiling for wasm32). When depending on the webp crate, it pulls in image with all default features.

Can you please change your dependency on image to include default-features = false, and only explicitly enable the features you need in the img feature?

If you'd like, I can send a PR which implements this change.
@jaredforth jaredforth added the enhancement New feature or request label Apr 23, 2021
@jaredforth
Copy link
Owner

@pchickey Hi Pat! Go ahead and send a PR and I'll work it in

pchickey added a commit to pchickey/webp that referenced this issue Apr 23, 2021
@pchickey
depend on image with default-features = false
a39e5a9 
This crate doesn't make use of any of the codecs in `image`, which can
be individually enabled with cargo features, and are all enabled by
default. Setting default-features=false allows applications that
depend on `webp` and `image` to select exactly what `image` features
they need.

Fixes jaredforth#4
@pchickey pchickey mentioned this issue Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchickey pchickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

depend on image with default-features = false pchickey/webp
2 participants
@pchickey @jaredforth