Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on old passport is breaking code that uses newer passport. #28

Closed
jdfm opened this issue May 12, 2014 · 3 comments
Closed

Dependency on old passport is breaking code that uses newer passport. #28

jdfm opened this issue May 12, 2014 · 3 comments

Comments

@jdfm
Copy link

jdfm commented May 12, 2014

I was testing the LocalStrategy for a login page I was building and I was expecting to see the req object in the passport.serializeUser method, but it was never there, after some sleuthing I found that the version of passport that is being included with passport-openid is substituting the newer version of passport that I actually wanted to use. Code that is being used:

node_modules/passport-openid/node_modules/passport/lib/passport/http/request.js

Code that should be in current use instead:

node_modules/passport/lib/passport/http/request.js

@filso
Copy link

filso commented Sep 23, 2015

+1

@jaredhanson
Copy link
Owner

Published package with fix to npm as passport-openid@0.4.0.

@filso
Copy link

filso commented Sep 24, 2015

@jaredhanson could you also update package.json in passport-paypal to new version?
https://github.com/jaredhanson/passport-paypal/blob/master/package.json#L25

filso added a commit to filso/passport-paypal that referenced this issue Sep 24, 2015
Fix cascading bug of requiring older version of passport - jaredhanson/passport-openid#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants