Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow export account without domains #86

Conversation

MaZderMind
Copy link
Contributor

This PR allows creating an account which can then be used to create multiple clients for multiple domain requests handled in parallel.

Example:

    import simple_acme_dns
    account_client = simple_acme_dns.ACMEClient(
        directory="https://acme-staging-v02.api.letsencrypt.org/directory" if USE_LE_STAGING_ENV else "https://acme-v02.api.letsencrypt.org/directory",
        new_account=True,
        generate_csr=False
    )
    account = account_client.export_account(save_certificate=False, save_private_key=False)

…

    client = simple_acme_dns.ACMEClient.load_account(account)
    client.domains = [domain, f'*.{domain}']
    client.nameservers = ["8.8.8.8", "8.8.4.4"]
    client.generate_private_key_and_csr(key_type='ec384')
    client.request_verification_tokens()

@MaZderMind MaZderMind force-pushed the smedia-allow_export_account_without_domains branch from a864abc to 9c584dc Compare May 23, 2024 08:56
Copy link
Owner

@jaredhendrickson13 jaredhendrickson13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jaredhendrickson13 jaredhendrickson13 merged commit 960be59 into jaredhendrickson13:master May 23, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants