Fix vague InductionSmelter recipe removal issues. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even using getPrimaryInput() and getSecondaryInput() on a recipe is not enough, as this order will sometimes fail to remove recipes, especially those that use multiple items for input. According to King Lemming, the correct way to remove these recipes is to swap the order of the items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to King Lemming on the COFH Discord, the correct way to handle recipes for the induction smelter that use multiple of a single item is to swap the order of ingredients.
Not swapping the order will simply result in the recipe not being removed, but no error being raised. I first though to generate an error saying to swap the order of inputs in ZenScript, but then it seemed obvious just to try calling removeRecipe a second time.