Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollbar covers menu icons #1

Closed
sknebel opened this issue Jul 10, 2017 · 6 comments
Closed

scrollbar covers menu icons #1

sknebel opened this issue Jul 10, 2017 · 6 comments

Comments

@sknebel
Copy link

sknebel commented Jul 10, 2017

grafik

Firefox on Win10
@joebubna
Copy link

joebubna commented Jul 10, 2017 •
edited
Loading

I just encountered the same thing on Chrome 58.0.3029.110 (64-bit), running on a Mac.

@RichiCoder1
Copy link

It's because it should be overflow-x: auto rather than overflow-x: scroll.

RichiCoder1 added a commit to RichiCoder1/pell that referenced this issue Jul 10, 2017
@RichiCoder1
(jaredreichGH-1) Fix action bar scroll bar being forced
cc46bb7 
Currently the scroll bar is being forced to always appear. I assume the intent was to have it show up on overflow. Though you might still have height issues on collapse.
@tutman96
Copy link

Wouldn't that also cover the buttons if it needed the scrollbar? like on mobile?

@brooksbecton
Copy link

brooksbecton commented Jul 10, 2017 •
edited
Loading

Looks like the class .pell-actionbar has a fixed height of 30px. I changed the height to 10% in chrome debug and that helped with cover up.

Also adding @RichiCoder1 'overflow-x: auto' helped the full screen from having a extraneous toolbar.

Windows 10 Version 61.0.3150.0 (Official Build) canary (64-bit)

@CodeBrauer
Copy link

CodeBrauer commented Jul 11, 2017 •
edited
Loading

This problem appears on any OS that has always-visible scrollbars (e.g. current macOS on default settings doesn't).

I think this is intended to work like this on macOS / mobile:
gif

As mentioned by @RichiCoder1 this can be solved by changing overflow-x from scroll to auto: pell.scss

However on viewports < ~480px the issue will appear again (on any OS that has always-visible scrollbars)

Related #7 #9

@jaredreich
Copy link
Owner

Thanks everyone for reporting and commenting, fixed in 722308c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sknebel @CodeBrauer @joebubna @RichiCoder1 @jaredreich @brooksbecton @tutman96