Carthage Support #51
Closed
Carthage Support #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix static analyzer warning.
JTSImageViewControllerBackgroundStyle_ScaledDimmedBlurred and JTSImageViewControllerBackgroundStyle_ScaledDimmed do not exist. Replaced with JTSImageViewControllerBackgroundOption_Scaled
Fixes issues with building the sample project and with the readme.
|
What the heck is happening, why did it add so many commits :D |
|
Oh those are commits from the master branch as I synced them. Shouldn't matter I guess. |
|
Excuse me? Would you mind explaining me what's wrong with this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jared,
Thanks for writing this component.
I added a dynamic framework so that people who use Carthage can use this too.
I have also added
completionparameter to the-showFromViewController:transition:as I needed this too.Let me know what you think