-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Larave 5.4 #159
Comments
+1 |
+1 |
Agreed. Looks like just an update to composer.json |
@redroses if that's the case, it should be fairly easy to update. |
+1 |
2 similar comments
+1 |
+1 |
It looks like the composer.json was updated quite a while ago to accept illuminate/database 5.4 (#152), but it seems that the composer repository has not been updated and it is still only accepts 5.3. |
+1 - This is a great library! Looks like only a minor update like @nospoon mentions to get it working for 5.4 |
Just noticed, there is already a pull request waiting to be merged to fix the version requirement. Not sure why it's been sitting there for 28 days now. |
+1 - @nospoon It looks like this change was merged, no? However, still the same result, unable to resolve illuminate\database dependency. |
@aaronsnyder The original PR to introduce 5.4 was indeed merged, however it contained an error (single | instead of ||), there is a second PR to correct that but this one still hasn't been merged (#155) |
I think sofa/hookable should be updated as well. |
I had to create a fork for this, you can use |
It seems like there's a problem now! |
I have no clue what I'm doing there, not enough experience regarding eloquent bindings, but I noticed that the values weren't passed into the query, this commit seems to fix things for me. I'm sure there's a better solution though |
Sorry guys, this patch doesn't work. It's fine as long as you just call the |
+1 |
3 similar comments
+1 |
+1 |
+1 |
it's not that simple, here's another issue we would have to take care of #166 |
those interested on a working 5.4 version should use this repo until we manage to merge with @jarektkaczyk's repo: Currently I have sent a PR with a couple of fixes. These are the failing errors as of now.
|
@diego-vieira this should fix the failure ortic#2 |
@Remo indeed, but we can always merge your repo with this one as soon as @jarektkaczyk is back. |
@Remo Made a pull request that would IMHO pass all Tests and errors ... Would integrate in my project after your merge my pull request and let you know how it goes ... Feedback is much appreciated ... |
Thanks, check this https://travis-ci.org/ortic/eloquence |
I will look into it ASAP. Thanks
Jarek Tkaczyk
softonsofa :: development with pleasure
…On Mar 21, 2017 19:31, "Ebrahim Bangdiwala" ***@***.***> wrote:
@Remo <https://github.com/Remo> Made a pull request that would IMHO pass
all Tests and errors ...
Would integrate in my project after your pull request and let you know how
it goes ...
Feedback is much appreciated ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGm5srWtgraFCDcaL73esoDFwb87T4eGks5rn7UBgaJpZM4LyVDx>
.
|
Hey @jarektkaczyk , I made the PR on @Remo's repo ... Thanks to @jarektkaczyk , @Remo , @diego-vieira for the great work ... |
Hi @jarektkaczyk, have you been able to look at @Remo's PR? It's been a month. It would great to get your awesome package working again in Laravel 5.4. |
upgraded to 5.4 finally ;) https://github.com/jarektkaczyk/eloquence/tree/5.4 thanks to @Remo and everyone else who made effort, sorry it took so long |
Thanks @jarektkaczyk!!! and for the subsequent quick bug fix! |
I think we need an update. 😄
The text was updated successfully, but these errors were encountered: