fix(build): Move '@types/react' to devDependencies #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
babblebey
reviewed
Aug 30, 2024
babblebey
reviewed
Aug 30, 2024
babblebey
changed the title
babblebey
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Great stuff, thank you @DevYoma
Quick note for next time 😉
- I renamed the PR title prefixing the word
fix(build):to follow the conventional commit standard. Look it up
|
I'm glad I could help :) |
amiabl-programr
added a commit
to amiabl-programr/jargons.dev
that referenced
this pull request
Aug 31, 2024
fix(build): Move '@types/react' to devDependencies (jargonsdev#92)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
@type/reactdependency fromdependenciesand adds it to thedevDependenciesin the projectspackage.jsonfileRelated Issue
Fixes #21
Screenshots/Screencasts
Notes to Reviewer
I initially don't know what happened in the first commit. I ran
npm installafter moving@types/reactdependency to the the devDependency. But I did it well in the second commit.