Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about future development of the model #17

Closed
Bebra777228 opened this issue Apr 13, 2024 · 4 comments
Closed

Question about future development of the model #17

Bebra777228 opened this issue Apr 13, 2024 · 4 comments

Comments

@Bebra777228
Copy link

Hi! I really enjoyed your Colab Notebook and I have a couple of questions:

  1. Is there a plan to implement a feature for adding custom separation models?
  2. Will DeEcho-DeReverb and DeNoise models be added for more efficient separation?

Thank you in advance for your answer!

@jarredou
Copy link
Owner

jarredou commented Apr 13, 2024

Most of the upgrades are done after a new good model has been publicly released. I don't have the ressources to train good models myself so evolution will continue this way.

I don't have plans to implement VR arch models, I could probably add the FoxJoy dereverb model from UVR easily tho (as it's MDX-Net based and the code is already implemented for VocFT and InstHQ4, but hopefully better models for that task will be released this year.

@deton24
Copy link

deton24 commented Apr 13, 2024 via email

@Bebra777228
Copy link
Author

With each new model, the load on the GPU increases and can reach 13-14 GB. This leads to a slowdown in the processing process. I would like to know if optimization will be implemented to reduce the load on the GPU?

@jarredou
Copy link
Owner

jarredou commented Apr 14, 2024

You can lower BigShifts parameter to reduce the number of passes by model, I've already lowered the new default value (it was at 7 in previous version), the slowdown is mainly because BS-Roformer processing is 3x slower than MDX23C (InstVoc).

I'll see to add a "low memory" setting. It should be easy & quick to add but it will only influence vocals/instrumentals separation.
For the 4-stem separation, when Demucs is used, it would need a full code rewrite, and I didn't have time to do that for latest update. It's on my todolist for next version, but I don't know when I'll have time to spend on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants