Avoid std::regex initialization during dlopen #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you able to get your user to try it with this fix to at least see if it fixes their actual problem. |
|
I have already built a new release (indexed_bzip2 1.5.0) using this forked version of cxxopt and asked @ozancaglayan to try it out. I am yet to hear back. |
|
This seems like a good change anyway, but I would like to hear back if it solves the original problem. |
It (or some other change between indexed_bzip2 1.4.0 and 1.5.0) did fix the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested workaround for #405. Unfortunately, I have no minimal reproducer to test it against.
This change is