Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running 'make' fails during test of test/libc/calls/hefty/spawnve_test.com.runs #25

Closed
maroneze opened this issue Jan 4, 2021 · 1 comment

Comments

@maroneze
Copy link

maroneze commented Jan 4, 2021

On a Fedora 32 (gcc 10.2.1), after cloning the Github repository (currently on commit 2831689) and running make, I get:

♥cosmo
error:test/libc/calls/hefty/spawnve_test.c:55: spawnve_testExit()
        ASSERT_NE(-1, (pid = spawnlp(0, NULL, CMD, CMD, ARG, "exit 42", NULL)))
                need -1 (or 0xffffffffffffffffffffffffffffffff) ≠
                 got -1 (or 0xffffffffffffffffffffffffffffffff)
        ENOMEM/err=12/errno:12/GetLastError:0
        o//test/libc/calls/hefty/spawnve_test.com
1 / 4 tests failed
make: *** [build/rules.mk:76: o//test/libc/calls/hefty/spawnve_test.com.runs] Error 1

The .com target seems to compile fine, it's just the .runs target that seems to fail. It's also the only test which fails (if I comment it out, make succeeds for everything else).

@jart
Copy link
Owner

jart commented Jan 16, 2021

Marking as duplicate of #14. I recommend just deleting spawnve_test.c for now. Your environment variables likely have some type of value that's causing this test to fail, e.g. CC, PATH, etc. We're probably just going to delete this test. But if you can investigate further and help us better understand the 'why' of this issue, it'd be a huge help.

@jart jart closed this as completed Jan 16, 2021
jart added a commit that referenced this issue Jan 26, 2021
For the first time ever, all tests in this codebase now pass, when
run automatically on macos, freebsd, openbsd, rhel5, rhel7, alpine
and windows via the network using the runit and runitd build tools

- Fix vfork exec path etc.
- Add XNU opendir() support
- Add OpenBSD opendir() support
- Add Linux history to syscalls.sh
- Use copy_file_range on FreeBSD 13+
- Fix system calls with 7+ arguments
- Fix Windows with greater than 16 FDs
- Fix RUNIT.COM and RUNITD.COM flakiness
- Fix OpenBSD munmap() when files are mapped
- Fix long double so it's actually long on Windows
- Fix OpenBSD truncate() and ftruncate() thunk typo
- Let Windows fcntl() be used on socket files descriptors
- Fix Windows fstat() which had an accidental printf statement
- Fix RHEL5 CLOCK_MONOTONIC by not aliasing to CLOCK_MONOTONIC_RAW

This is wonderful. I never could have dreamed it would be possible
to get it working so well on so many platforms with tiny binaries.

Fixes #31
Fixes #25
Fixes #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants