Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printvideo.com failing on piledriver #37

Closed
ritschwumm opened this issue Jan 31, 2021 · 6 comments
Closed

printvideo.com failing on piledriver #37

ritschwumm opened this issue Jan 31, 2021 · 6 comments
Assignees

Comments

@ritschwumm
Copy link

i'm running ubuntu focal on an "AMD FX(tm)-8350 Eight-Core Processor" -
should this work, or am i missing something?
and if it should, what can i do to help making it work?

@jart jart changed the title printvideo.com and printimage.com crash with "illegal instruction" printvideo.com failing on piledriver Jan 31, 2021
@jart jart self-assigned this Jan 31, 2021
@jart
Copy link
Owner

jart commented Jan 31, 2021

Thanks for the report. You can absolutely help! We need to find the faulting instruction pointer address. I've enabled crash reports on the binary and pushed an update. Could you please run these commands:

export GDB=
rm -f printvideo.com*
wget https://justine.lol/crabrave.mpg
wget https://justine.lol/printvideo.com
wget https://justine.lol/printvideo.com.dbg
chmod +x printvideo.com
./printvideo.com -s crabrave.mpg

@ritschwumm
Copy link
Author

well, that's interesting: this build just works without a hitch.

@jart
Copy link
Owner

jart commented Jan 31, 2021

In that case this is likely a duplicate of #16 and I simply forgot to push a new release of the printvideo.com binary. Thanks again for the report! If there's anything else, please file an issue. I'm at your service.

@jart jart closed this as completed Jan 31, 2021
@jart
Copy link
Owner

jart commented Jan 31, 2021

Also would love to hear any feedback you have on the printvideo.com program, while you're here. I wrote it with the goal of making it the best. It has useful keyboard shortcuts like t for true color mode, s for statistics, ctrl+g for unsharp masking. You can even change the illumination parameter to simulate different types of light bulbs by pressing l and L.

@ritschwumm
Copy link
Author

so.. some feedback, in order of specifity:

  • the whole concept of cosmopolitan is amazing, one of the coolest hack's i've ever seen.
  • i can't imagine yet where to use it, but sooner or later i'll probably find some application where it's exactly what i need. if i can bring myself to touch C again, which still feels wrong to me after 30 years of coding in quite a few languages.
  • with printvideo.com, there's 3 keyboard shortcuts that i instinctively expected to work, and which didn't: q for quitting, and cursor righ/left for skipping forward and backwards
  • printimage.com which was previously crashing now works for me

@jart
Copy link
Owner

jart commented Feb 3, 2021

Thanks for the feedback.

I believe higher level languages should adopt Cosmopolitan as an implementation detail. It'll give them an advantage that no competitor has, which is tiny performant portable native binaries and painless native modules. The goal of this project is to fix the system integration problem. That'll make life better for everyone regardless of language. Although anyone who enjoys C will find that using Cosmopolitan make writing it much more pleasant.

As for printvideo, I'm going to add the q shortcut, since there's no excuse for not having it. I agree that left/right seek shortcuts should happen which I worked to address in the past but ended up kicking the can down the road. Contributions are welcome on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants