Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jarun#729] fixed url value passed to update_rec() from CLI #730

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[jarun#729] fixed url value passed to update_rec() from CLI #730

merged 1 commit into from
Apr 8, 2024

Conversation

LeXofLeviafan
Copy link
Collaborator

fixes #729:

  • value of the default url parameter of update_rec() passed from CLI should be None, not ''

chenrui333
chenrui333 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch works for my pr, Homebrew/homebrew-core#168219

@jarun jarun merged commit aa24d6d into jarun:master Apr 8, 2024
1 check passed
@jarun
Copy link
Owner

jarun commented Apr 8, 2024

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
@LeXofLeviafan LeXofLeviafan deleted the fix-homebrew branch August 24, 2024 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression test failure with 4.9 release
3 participants
@LeXofLeviafan @jarun @chenrui333