ci: add py3.12 support #731
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
|
CI fails. Please check. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
| [testenv:quick] | ||
| basepython = {env:BASEPYTHON:py311} | ||
| basepython = {env:BASEPYTHON:py312} |
There was a problem hiding this comment.
Note that this change replaces the default python version (unless explicitly specified)
…I believe 3.12 is still disabled in my repo as not all core packages support it as of yet.
There was a problem hiding this comment.
but I guess we can find out the issues when we make this switch?
| @@ -228,7 +228,7 @@ class ApiBookmarkSearchView(MethodView): | |||
|
|
|||
| def get(self): | |||
| arg_obj = request.args | |||
| keywords = arg_obj.getlist('keywords') | |||
| keywords = arg_obj.getlist('keywords') # pylint: disable=E1101 | |||
There was a problem hiding this comment.
Instead of disabling typecheck, shouldn't you clarify the type of request.args?
There was a problem hiding this comment.
@LeXofLeviafan what change is required here? I cna make the change and move forward. Please share the code.
There was a problem hiding this comment.
Instead of disabling type check, the correct way to fix the pylint error is to clarify the type of request.args (# type: MultiDict, probably along with an import fromwerkzeug.datastructures).
This applies to both instances of E1101.
There was a problem hiding this comment.
I am approving this change. Please raise the PR.
|
@LeXofLeviafan please approve when this is ready. |
|
Thank you! |
I have migrated the brew build into py3.12, and it works out fine, thus adding the support in here as well.