[jarun#753] temporarily block flake-admin-v2 & actualize install instructions #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeXofLeviafan
commented
Jul 20, 2024
| except Exception: | ||
| app.logger.warning('failed to init locale') | ||
| except Exception as e: | ||
| app.logger.warning(f'failed to init locale ({e})') |
There was a problem hiding this comment.
This includes the error message into the warning, making it easier to tell what happened
LeXofLeviafan
commented
Jul 20, 2024
| $ pip3 install ".[server]" | ||
| $ # server with reverse_proxy | ||
| $ pip3 install ".[server,reverse_proxy]" |
There was a problem hiding this comment.
[reverse_proxy] is no longer present in setup.py
LeXofLeviafan
commented
Jul 20, 2024
| @@ -20,33 +20,28 @@ So be sure to have `python3`, `python3-pip` , `python3-dev`, `libffi-dev` packag | |||
| #### Dependencies | |||
|
|
|||
| ``` | |||
| $ python3 -m pip install --user --upgrade pip | |||
There was a problem hiding this comment.
Depending on OS, pip install --user is no longer allowed (unless you pass --break-system-packages as well)
LeXofLeviafan
commented
Jul 20, 2024
| @@ -20,33 +20,28 @@ So be sure to have `python3`, `python3-pip` , `python3-dev`, `libffi-dev` packag | |||
| #### Dependencies | |||
|
|
|||
| ``` | |||
| $ python3 -m pip install --user --upgrade pip | |||
| $ python3 -m pip install --user virtualenv | |||
| $ python3 -m virtualenv env | |||
There was a problem hiding this comment.
Installing virtualenv is no longer necessary: the venv module is included in basic Python installation (and accomplishes the same result)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake-adminv2 until able to migrate properly when it's released (see TODO: support the incoming v2.0 release of flask-admin #753)[reverse_proxy]flag – see [jarun#685] included flask-reverse-proxy-fix into the package #722)