apply dialog fixes to bookmark dialogs #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeXofLeviafan
commented
Aug 25, 2024
|
|
||
| /* limit dialog height with a scrollbox */ | ||
| .modal-content { | ||
| max-height: calc(100vh - 60px); |
There was a problem hiding this comment.
Previous implementation assumed same-sized dialog header, but Bookmarks dialogs are larger; so I moved dynamic size to the dialog frame instead (…which required a few extra hacks to make the scrollbox work correctly).
LeXofLeviafan
commented
Aug 25, 2024
| .modal-body thead { | ||
| position: sticky; | ||
| /* setting `top:` with JS, to account for theme differences */ | ||
| } |
There was a problem hiding this comment.
position: sticky has no effect unless a position size is defined… and <thead> only exists in Stats dialogs
LeXofLeviafan
commented
Aug 25, 2024
| /* overriding icon-button text color with theme color */ | ||
| .modal-header .close { | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
This is a better match for existing Bootstrap styles
|
Thank you! |
|
Can you please have a look if some of the open issues can be closed... if your time permits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…After a few more checks I realized the dialogs on the Bookmarks page had the same issues as on those the Stats page (+they add an unnecessary scrollbar on the main window just because). So I renamed the CSS file (which only contained dialog styles anyway) and did a few more adjustments to make sure the fixes work on all pages.