This repository has been archived by the owner on Mar 5, 2022. It is now read-only.
Stopped working? #372
Comments
|
Same, first time using this tool a few minutes ago. |
|
Looks like it. Attached the response for @zmwangx to take a look. |
|
Weirdly enough, for me- the following works: googler --debug aaaaBut the following doesn't: googler --debug hi |
|
same for me. Worked up to yesterday. |
zmwangx
added a commit
to zmwangx/googler
that referenced
this issue
Oct 3, 2020
Fixes jarun#372, hopefully. Old parser is kept just in case the new strucutre isn't served to every domain / every UA / every user. Parser now capable of parsing multiple metadata fields too, e.g. "Released", "Genre", etc. for songs. Wikipedia search results often have these metadata fields, it seems. I have chosen " | " as the delimiter in our single-line output, which is of course debatable.
zmwangx
added a commit
to zmwangx/googler
that referenced
this issue
Oct 3, 2020
Fixes jarun#372, hopefully. Old parser is kept just in case the new structure isn't served to every domain / every UA / every user. Parser now capable of parsing multiple metadata fields too, e.g. "Released", "Genre", etc. for songs. Wikipedia search results often have these metadata fields, it seems. I have chosen " | " as the delimiter in our single-line output, which is of course debatable.
Merged
jarun
pushed a commit
that referenced
this issue
Oct 3, 2020
* Fix parser for new markup structure Fixes #372, hopefully. Old parser is kept just in case the new structure isn't served to every domain / every UA / every user. Parser now capable of parsing multiple metadata fields too, e.g. "Released", "Genre", etc. for songs. Wikipedia search results often have these metadata fields, it seems. I have chosen " | " as the delimiter in our single-line output, which is of course debatable. * Fix Result.__hash__ Result.__hash__ isn't actually used I believe (just wrote it for completeness), but still it should be corrected. Caught by Pylance.
|
thank you jarun. I reinstalled from the git master and now works perfectly again thanks to your fork merge |
|
@jarun thanks for the quick update to fix. To any others needing to solve this, I ran: |
lol that's basically what I said!! |
zmwangx
added a commit
to zmwangx/googler
that referenced
this issue
Oct 5, 2020
print appropriate messages based on project status along with the "no results"
warning.
Rationale: there have been enough Google-breaks-everything shitstorms, it's
time to introduce a better protocol to reduce user confusion during these
trying periods.
Here's the protocol:
- Once a report is confirmed and proven to be non-transient (e.g. still reproducible after 24 hours), regardlessly of whether a fix can be made available immediately, the epoch in `googler` and `info.json` should be advanced to the date of the report (in UTC), and the issue number recorded. `info.json` should look like:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": false,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Issue acknowledged, not fixed.
No results.
Your version of googler is broken due to Google-side changes.
The issue is tracked at jarun#372.
```
- Once a fix is committed to master, `fixed_on_master` should be set to `true`:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Fixed on master, not released.
No results.
Your version of googler is broken due to Google-side changes.
The fix has been pushed to master, pending a release.
Please download the master version https://git.io/googler or wait for a release.
```
- Once the fix is released, `fixed_in_released` should be updated to the version tag:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": "v4.3"
}
```
At this point users would see a message like this:
```console
$ googler hello # Fix released.
No results.
Your version of googler is broken due to Google-side changes.
A new version, v4.3, has been released to address the changes.
Please upgrade to the latest version.
```
zmwangx
added a commit
to zmwangx/googler
that referenced
this issue
Oct 5, 2020
print appropriate messages based on project status along with the "no results"
warning.
Rationale: there have been enough Google-breaks-everything shitstorms, it's
time to introduce a better protocol to reduce user confusion during these
trying periods.
Here's the protocol:
- Once a report is confirmed and proven to be non-transient (e.g. still reproducible after 24 hours), regardlessly of whether a fix can be made available immediately, the epoch in `googler` and `info.json` should be advanced to the date of the report (in UTC), and the issue number recorded. `info.json` should look like:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": false,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Issue acknowledged, not fixed.
No results.
Your version of googler is broken due to Google-side changes.
The issue is tracked at jarun#372.
```
- Once a fix is committed to master, `fixed_on_master` should be set to `true`:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Fixed on master, not released.
No results.
Your version of googler is broken due to Google-side changes.
The fix has been pushed to master, pending a release.
Please download the master version https://git.io/googler or wait for a release.
```
- Once the fix is released, `fixed_in_released` should be updated to the version tag:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": "v4.3"
}
```
At this point users would see a message like this:
```console
$ googler hello # Fix released.
No results.
Your version of googler is broken due to Google-side changes.
A new version, v4.3, has been released to address the changes.
Please upgrade to the latest version.
```
zmwangx
added a commit
to zmwangx/googler
that referenced
this issue
Oct 5, 2020
print appropriate messages based on project status along with the "no results"
warning.
Rationale: there have been enough Google-breaks-everything shitstorms, it's
time to introduce a better protocol to reduce user confusion during these
trying periods.
Here's the protocol:
- Once a report is confirmed and proven to be non-transient (e.g. still
reproducible after 24 hours), regardlessly of whether a fix can be made
available immediately, the epoch in `googler` and `info.json` should be
advanced to the date of the report (in UTC), and the issue number
recorded. `info.json` should look like:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": false,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Issue acknowledged, not fixed.
No results.
Your version of googler is broken due to Google-side changes.
The issue is tracked at jarun#372.
```
- Once a fix is committed to master, `fixed_on_master` should be set to `true`:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": false
}
```
At this point users would see a message like this:
```console
$ googler hello # Fixed on master, not released.
No results.
Your version of googler is broken due to Google-side changes.
The fix has been pushed to master, pending a release.
Please download the master version https://git.io/googler or wait for a release.
```
- Once the fix is released, `fixed_in_released` should be updated to the
version tag:
```json
{
"epoch": "20201001",
"tracking_issue": 372,
"fixed_on_master": true,
"fixed_in_release": "v4.3"
}
```
At this point users would see a message like this:
```console
$ googler hello # Fix released.
No results.
Your version of googler is broken due to Google-side changes.
A new version, v4.3, has been released to address the changes.
Please upgrade to the latest version.
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
googler -d:https://gist.github.com/097115/821c10653b18cc83d333329ab8371e9c
Both Ubuntu and macOS, both python 3.5.2 and 3.7.4. Worked just a few hours ago, and now suddenly returns no results (both 4.2 and the latest master).
The text was updated successfully, but these errors were encountered: