Jump to the next young file #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
requested changes
Jul 22, 2023
jarun
requested changes
Jul 23, 2023
ANtlord
force-pushed
the
young-files
branch
3 times, most recently
from
a590022
to
9f5ad01
Compare
N-R-K
reviewed
Jul 24, 2023
There was a problem hiding this comment.
Looks okay. But please remove this line from the commit message:
The starting position from which the next young file is searched is the current cursor position or the next position if the current position of the cursor points to a young file.
This is not the case anymore with the new loop. And even in the old loop, this was dead code:
- If initial file was young, it'd get skipped (before the loop).
- If initial file wasn't young, it'd get skipped as well (but this time inside the loop).
So the initial file was always being skipped anyways.
ANtlord
force-pushed
the
young-files
branch
2 times, most recently
from
4faf4f6
to
9d9394b
Compare
|
Looks like I should correct the patches also. Is that correct? |
N-R-K
approved these changes
Jul 24, 2023
Forward jumping to the next young file is implemented. The starting position from which the next young file is searched is the next position. If no young file has been found, the search starts from the beginning. It stops at the initial position where the search has started.
N-R-K
force-pushed
the
young-files
branch
2 times, most recently
from
8671b2b
to
dedf055
Compare
|
Weird, looks like the |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward jumping to the next young file is implemented.
The starting position from which the next young file is searched is the current cursor position or the next position if the current position of the cursor points to a young file.The starting position from which the next young file is searched is the next position. If there no young file has been found, the search starts from the beginning. It stops at the initial position where the search has started.