Refactor Remove/Empty/Destroy

[jarvisteach]

I'm not happy with how appJar removes widgets.

There are a few scenarios we should support:

• Hiding/Showing a widget
• Disabling/enabling a widget
• Destroying a widget
• Emptying a widget

At the moment we provide:

• .disable XXX (name)
• .enable XXX (name)
• .hide XXX (name)
• .show XXX (name)
• .remove XXX (name)
• .removeAllWidgets()

I propose:

• Introducing a new function: .empty XXX (name)
• Renaming remove to destroy
• Making .removeAllWidgets() a shortcut to .empty XXX(topLevel)

[jarvisteach]

The above functions are auto generated, and call .xxxWidgetType(kind, name)

.removeAllWidgets(True) if called when within a container should only empty that container, but I don't think it cleans out the widget manager, and it's not documented. But I'd rather not have to open the container to clear it...

[jarvisteach]

Bringing this across from issue #423

A common use case is to clear & repopulate a container.

This isn't straight-forward enough.

The code is already there in removeAllWidgets - it just needs adapting to be applied to a specific container.

It would also be good to be able to reset or keep the container settings in _prepContainer

• type - shouldn't change
• title - shouldn't change
• container - shouldn't change
• emptyRow - should change
• colCount - should change
• sticky - shouldn't change
• padx - shouldn't change
• pady - shouldn't change
• ipadx - shouldn't change
• ipady - shouldn't change
• expand - shouldn't change
• widgets - should change
• inputFont - shouldn't change
• labelFont - shouldn't change
• buttonFont - shouldn't change
• fg - shouldn't change

[jarvisteach]

Getting there! - remove/empty/destroy are all (just about) sharing the same code.

Only thing left is container settings & _initVars.
The following vars exist at the GUI level, but should be moved around:

• doFlash - This should exist for each label, can check length of flashLabel array, and if greater than 0, loop through and check each one's doFlash setting...
• validateNumeric & validateSpinBox - These should be refactored into the entry class:
• hasTitleBar - should probably exist for all windows?
• winIcon - should probably exist for all windows?
• labWidth - not even used, but should exist for all containers...
• splashConfig - GUI setting
• dnd - GUI setting
• accessMade - GUI setting, BUT need to make sure it's not deleted?

[jarvisteach]

Where we're at:

• doFlash - will leave as global, minimal use case
• hasTitleBar - separate issue Add Menubars/Toolbars/Statusbars to Subwindows #508
• winIcon - now stored in each window
• labWidth - removed - could be reintroduced as container property
• validateNumeric & validateSpinBox - moved into new issue Entry Update Backlog #527
• accessMade - reset on removeAll
• splashConfig - GUI setting
• dnd - GUI setting

[jarvisteach]

Closing as I think it's all done!