Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

1.3.0 #2135

Closed
paulmillr opened this Issue · 23 comments

6 participants

@paulmillr

Hey coffee bros, I think it's a good time to release 1.3.0.

It has many changes (even breaking, like use strict) so if it will be released earlier, compatibility breaking will affect less people.

@michaelficarra
Collaborator

Yes, it's getting to be around that time again. 116 commits, and quite a few breaking changes.

@jashkenas
Owner

Agreed. Let's do it.

@TrevorBurnham
Collaborator

No 1.2.1? Won't this be a bugfix release?

@jashkenas
Owner

Either way. Let's see what the balance of fixes / new features (like strict mode warnings) is.

@michaelficarra
Collaborator

There were way too many breaking changes introduced since 1.2.0, particularly the "use strict" related changes. It should be 1.3.0 to indicate that.

@TrevorBurnham
Collaborator

You mean the #2021 stuff? Hmm, I suppose the new reserved words will break a significant amount of code, yes. (Plenty of let function and yield functions out there.) So fair enough, 1.3.0 it is.

@michaelficarra
Collaborator

And disallowing duplicate parameters. And disallowing uppercase radix prefixes. And disallowing zero-prefixed number literals. And disallowing octal escape sequences. Pretty much all of it is stuff that will break some script out there.

@TrevorBurnham
Collaborator

And disallowing duplicate parameters. And disallowing uppercase radix prefixes. And disallowing zero-prefixed number literals. And disallowing octal escape sequences.

Right, I'm just guessing that those things are much rarer than using those reserved words as variable names. Could be wrong. I know you're a fan of duplicate parameters.

@TrevorBurnham
Collaborator

Just realized how big the octal thing is, since every mkdir call (for instance) uses an octal. Octals like 0o755 don't work in 1.2.0 (it just says Unexpected 'IDENTIFIER'), and they're the only octals that work on master. Ouch.

I'd really like to see at least one transitional release that accepts both formats, with a warning about the 0755 format rather than an error.

@michaelficarra
Collaborator

It's so easy to change the octal literals, especially with the helpful error we give:

$ coffee -ep 0755
SyntaxError: octal literals '0755' must be prefixed with '0o' on line 1
@jashkenas
Owner

Yep -- I'm not a big fan of transitional releases, especially since you can continue using your "compiled-with-1.2.0-javascript" alongside your "compiled-with-1.3.0-javascript" without having any problems.

@paulmillr

Any issues blocking this?

As I know, only package.json & changelog need to be updated. I can submit pullreq for this.

@jashkenas
Owner

I want to look through some of the more important open tickets, and document changes ... but yes -- there's nothing major blocking this. If someone works on a pull req and it gets a thorough review from at least @michaelficarra, we could use that for a 1.3.0

@ChrisCinelli

Last comment was 1 month ago. Is it the right time for a new release or not ? ;-)

@michaelficarra
Collaborator

Not exactly. But you're right, a release is needed so badly.

edit: whoops, I read "commit". You said "comment".

@michaelficarra
Collaborator

Pull requests I'd like to see either merged or closed before releasing 1.3.0: #1533, #1788, #1820, #1960, #1968, #2026, #2070

@jashkenas
Owner

@michaelficarra Would you consider that an exhaustive list of what's needed for a 1.3.0?

@jashkenas
Owner

Alright -- all closed.

@michaelficarra
Collaborator

Would you consider that an exhaustive list of what's needed for a 1.3.0?

Certainly.

@jashkenas
Owner

Working on the changelog now -- feel free to pop into IRC if you'd like to make sure I don't miss anything.

@michaelficarra
Collaborator

Closing. 1.3.0 has been released.

@TrevorBurnham
Collaborator
@paulmillr

Fuck yes. Thanks bros!

@wyattanderson wyattanderson referenced this issue from a commit in wyattanderson/cakefile-template
@wyattanderson wyattanderson Swapping octal literals for hex literals
Zero-prefixed octal literals are errors in CoffeeScript >1.3.0. See:

jashkenas/coffeescript#2135
jashkenas/coffeescript#2021
4f426f6
@wyattanderson wyattanderson referenced this issue in twilson63/cakefile-template
Closed

Swapping octal literals for hex literals #4

@vendethiel vendethiel added the meta label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.