1.3.0 #2135

Closed
paulmillr opened this Issue Feb 23, 2012 · 23 comments

Comments

Projects
None yet
6 participants

Hey coffee bros, I think it's a good time to release 1.3.0.

It has many changes (even breaking, like use strict) so if it will be released earlier, compatibility breaking will affect less people.

Collaborator

michaelficarra commented Feb 24, 2012

Yes, it's getting to be around that time again. 116 commits, and quite a few breaking changes.

Owner

jashkenas commented Feb 25, 2012

Agreed. Let's do it.

Collaborator

TrevorBurnham commented Feb 29, 2012

No 1.2.1? Won't this be a bugfix release?

Owner

jashkenas commented Feb 29, 2012

Either way. Let's see what the balance of fixes / new features (like strict mode warnings) is.

Collaborator

michaelficarra commented Feb 29, 2012

There were way too many breaking changes introduced since 1.2.0, particularly the "use strict" related changes. It should be 1.3.0 to indicate that.

Collaborator

TrevorBurnham commented Feb 29, 2012

You mean the #2021 stuff? Hmm, I suppose the new reserved words will break a significant amount of code, yes. (Plenty of let function and yield functions out there.) So fair enough, 1.3.0 it is.

Collaborator

michaelficarra commented Feb 29, 2012

And disallowing duplicate parameters. And disallowing uppercase radix prefixes. And disallowing zero-prefixed number literals. And disallowing octal escape sequences. Pretty much all of it is stuff that will break some script out there.

Collaborator

TrevorBurnham commented Feb 29, 2012

And disallowing duplicate parameters. And disallowing uppercase radix prefixes. And disallowing zero-prefixed number literals. And disallowing octal escape sequences.

Right, I'm just guessing that those things are much rarer than using those reserved words as variable names. Could be wrong. I know you're a fan of duplicate parameters.

Collaborator

TrevorBurnham commented Mar 5, 2012

Just realized how big the octal thing is, since every mkdir call (for instance) uses an octal. Octals like 0o755 don't work in 1.2.0 (it just says Unexpected 'IDENTIFIER'), and they're the only octals that work on master. Ouch.

I'd really like to see at least one transitional release that accepts both formats, with a warning about the 0755 format rather than an error.

Collaborator

michaelficarra commented Mar 5, 2012

It's so easy to change the octal literals, especially with the helpful error we give:

$ coffee -ep 0755
SyntaxError: octal literals '0755' must be prefixed with '0o' on line 1
Owner

jashkenas commented Mar 5, 2012

Yep -- I'm not a big fan of transitional releases, especially since you can continue using your "compiled-with-1.2.0-javascript" alongside your "compiled-with-1.3.0-javascript" without having any problems.

Any issues blocking this?

As I know, only package.json & changelog need to be updated. I can submit pullreq for this.

Owner

jashkenas commented Mar 8, 2012

I want to look through some of the more important open tickets, and document changes ... but yes -- there's nothing major blocking this. If someone works on a pull req and it gets a thorough review from at least @michaelficarra, we could use that for a 1.3.0

Last comment was 1 month ago. Is it the right time for a new release or not ? ;-)

Collaborator

michaelficarra commented Apr 7, 2012

Not exactly. But you're right, a release is needed so badly.

edit: whoops, I read "commit". You said "comment".

Collaborator

michaelficarra commented Apr 8, 2012

Pull requests I'd like to see either merged or closed before releasing 1.3.0: #1533, #1788, #1820, #1960, #1968, #2026, #2070

Owner

jashkenas commented Apr 10, 2012

@michaelficarra Would you consider that an exhaustive list of what's needed for a 1.3.0?

Owner

jashkenas commented Apr 10, 2012

Alright -- all closed.

Collaborator

michaelficarra commented Apr 10, 2012

Would you consider that an exhaustive list of what's needed for a 1.3.0?

Certainly.

Owner

jashkenas commented Apr 10, 2012

Working on the changelog now -- feel free to pop into IRC if you'd like to make sure I don't miss anything.

Collaborator

michaelficarra commented Apr 10, 2012

Closing. 1.3.0 has been released.

Collaborator

TrevorBurnham commented Apr 10, 2012

Happy to see this. Thanks, Jeremy.

On Apr 10, 2012, at 3:01 PM, Michael Ficarrareply@reply.github.com wrote:

Closing. 1.3.0 has been released.


Reply to this email directly or view it on GitHub:
jashkenas#2135 (comment)

Fuck yes. Thanks bros!

wyattanderson referenced this issue in twilson63/cakefile-template May 13, 2012

Closed

Swapping octal literals for hex literals #4

vendethiel added the meta label Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment