Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-fix for 2891 #2892

Closed
wants to merge 1 commit into from
Closed

quick-fix for 2891 #2892

wants to merge 1 commit into from

Conversation

hden
Copy link
Contributor

@hden hden commented Mar 26, 2013

Addressing #2891
Currently fork() for .coffee files requires Node.js 0.9+
Ignore the test when process.version does not match the requirement.

@michaelficarra
Copy link
Collaborator

This will fail to run the tests in node 1.0.0 through 1.0.8. Make sure the minor version is 0.

@epidemian
Copy link
Contributor

Is this necessary? Shouldn't the CS developers have the latest Node?

In case it is necessary, this is the second time we're asking for version numbers, could we consider using something node-semver? (it comes with npm, so i don't think it's a significant overhead)

@jashkenas
Copy link
Owner

Is this necessary? Shouldn't the CS developers have the latest Node?

Yep, we don't need this.

In case it is necessary, this is the second time we're asking for version numbers

I'd really like to not ever ask for version numbers, if at all possible. Let's aim for that, instead of making it easier.

@bobbydavid
Copy link
Contributor

FWIW I'm a CS developer and I got tricked by this. I may be a moron, but... aren't we all?

How about the Cakefile emits a warning when we build or test with a Node version lower than the necessary version? It might save a bit of confusion for those of us coming back to Node after a brief hiatus :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants