Remove redundant empty string handing in _.toArray() #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the review for pull request jashkenas#2298, @jdalton requested that we add this check to handle the empty string case. However, I'm guessing he didn't realize that the first line of the function, `if (!obj) return [];`, already handles that case. As part of that pull request, @JonAbrams wisely added a test for the empty string case, so as long as tests are passing this change should be safe. See: jashkenas#2298 (comment)
|
Tests are failing for an unrelated reason: |
|
Closed and reopened the pull request to trigger a Travis rebuild. Tests are now green. |
|
Nice catch! |
michaelficarra
added a commit
that referenced
this pull request
Nov 18, 2015
Remove redundant empty string handing in _.toArray()
|
Thanks. |
|
No problem. Thanks for the great library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the review for pull request #2298, @jdalton requested that we add
this check to handle the empty string case. However, I'm guessing he didn't
realize that the first line of the function,
if (!obj) return [];, alreadyhandles that case.
As part of that pull request, @JonAbrams wisely added a test for the empty
string case, so as long as tests are passing this change should be safe.
See: #2298 (comment)