Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional style #2908

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Functional style #2908

wants to merge 79 commits into from

Commits on Dec 30, 2020

  1. Simplify _.iteratee

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    c22e1e9 View commit details
    Browse the repository at this point in the history

  2. Make _.contains generic over the collection type

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    ce15d38 View commit details
    Browse the repository at this point in the history

  3. Use _.find in _.each

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f0e9bc3 View commit details
    Browse the repository at this point in the history

  4. Use _.find in _.every and _.some

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    0b51eae View commit details
    Browse the repository at this point in the history

  5. Use _.each in createReduce

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f4e0f71 View commit details
    Browse the repository at this point in the history

  6. Use _.chain in _chainResult

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    11bdeab View commit details
    Browse the repository at this point in the history

  7. Slim down use of _.each in _.filter

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    3bc4c50 View commit details
    Browse the repository at this point in the history

  8. Use _.each in _.map

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    ea55aeb View commit details
    Browse the repository at this point in the history

  9. Import modules/iteratee.js for its side effect in modules/_cb.js

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    5092fb5 View commit details
    Browse the repository at this point in the history

  10. Use isArrayLike in _.isEmpty

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    008990f View commit details
    Browse the repository at this point in the history

  11. Remove an unnecessary check in _.omit

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    bd14ef1 View commit details
    Browse the repository at this point in the history

  12. Remove an unnecessary check from _.pick

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    38129be View commit details
    Browse the repository at this point in the history

  13. Deduplicate subexpressions in _.sample

    @jgonggrijp
    jgonggrijp committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    be5b8a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Reorder and document _.toArray

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    adfb2f8 View commit details
    Browse the repository at this point in the history

  2. Simplify and deduplicate _.uniq

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e842fd5 View commit details
    Browse the repository at this point in the history

  3. Use getLength in collectNonEnumProps

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5d73fb3 View commit details
    Browse the repository at this point in the history

  4. Use getLength in _.bindAll

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3753fe7 View commit details
    Browse the repository at this point in the history

  5. Refactor _.first and _.last, using getLength 

    This cost 5 bytes, but it's both more readable and more efficient.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d7393b4 View commit details
    Browse the repository at this point in the history

  6. Use getLength in _.invoke

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    18fd848 View commit details
    Browse the repository at this point in the history

  7. Remove switch pyramid of doom from _.restArguments

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    296be9e View commit details
    Browse the repository at this point in the history

  8. Simplify _.restArguments using array.slice

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    60319af View commit details
    Browse the repository at this point in the history

  9. Use _.last in _.invoke

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    645eafe View commit details
    Browse the repository at this point in the history

  10. Use _.initial in _.invoke

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    aac1042 View commit details
    Browse the repository at this point in the history

  11. Simplify internal flatten using array.push

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    431b84e View commit details
    Browse the repository at this point in the history

  12. Use array.push in _.partial

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5781d89 View commit details
    Browse the repository at this point in the history

  13. Factor out linearSearch and binarySearch base algorithms

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    81a7a77 View commit details
    Browse the repository at this point in the history

  14. Use linearSearch in _.has

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b4ab797 View commit details
    Browse the repository at this point in the history

  15. Use linearSearch in _.intersection

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5bc6d47 View commit details
    Browse the repository at this point in the history

  16. Use linearSearch in the internal flatten

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    eef39cd View commit details
    Browse the repository at this point in the history

  17. Use linearSearch in _methodFingerprint

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b63e425 View commit details
    Browse the repository at this point in the history

  18. Polish use of linearSearch in _.intersection

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    2fac273 View commit details
    Browse the repository at this point in the history

  19. Use linearSearch in _.mapObject

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9624b1b View commit details
    Browse the repository at this point in the history

  20. Use linearSearch in collectNonEnumProps

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3120fd2 View commit details
    Browse the repository at this point in the history

  21. Use linearSearch in internal flatten, again

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    3a326ad View commit details
    Browse the repository at this point in the history

  22. Use linearSearch in _.bindAll

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1f3562a View commit details
    Browse the repository at this point in the history

  23. Use linearSearch in _.chunk

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    cba898c View commit details
    Browse the repository at this point in the history

  24. Use linearSearch in _.isEqual

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    230fee1 View commit details
    Browse the repository at this point in the history

  25. Replace _.each by linearSearch in _.mixin and the array methods 

    This reduces internal dependencies, potentially slimming down bundles
substantially. Surprisingly, it also saves one byte on monolithic
standard Underscore.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a0ef35a View commit details
    Browse the repository at this point in the history

  26. Use linearSearch in _.pick

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8764f04 View commit details
    Browse the repository at this point in the history

  27. Use linearSearch in _.sample

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    bc0e942 View commit details
    Browse the repository at this point in the history

  28. Inline _.sortedIndex and _.sortedLastIndex

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    65c16db View commit details
    Browse the repository at this point in the history

  29. Replace linearSearch by _.times in _.sample

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8cfa13f View commit details
    Browse the repository at this point in the history

  30. Use _.times in _.unzip

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8edde7b View commit details
    Browse the repository at this point in the history

  31. Use linearSearch in collectNonEnumProps, again

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    19ba06e View commit details
    Browse the repository at this point in the history

  32. Swap the final parameters of linearSearch 

    One would expect that this saves bytes, since we get rid of a lot of
nulls. In reality, this change actually costs a byte. Nevertheless, it
simplifies the code a bit and also makes room for a possible future
end-of-range parameter.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5f46a25 View commit details
    Browse the repository at this point in the history

  33. Rename the final linearSearch parameter

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    dfd6d6b View commit details
    Browse the repository at this point in the history

  34. Use _.lastIndexOf in _.isEqual

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    13fca95 View commit details
    Browse the repository at this point in the history

  35. Use negated isUndefined in _.find

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    457a96d View commit details
    Browse the repository at this point in the history

  36. Use restArguments in _createAssigner

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7daecbe View commit details
    Browse the repository at this point in the history

  37. Use _.restArguments in _.intersection

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ce3f0ed View commit details
    Browse the repository at this point in the history

  38. Use _.restArguments in _.partial

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    c654128 View commit details
    Browse the repository at this point in the history

  39. Enable customization of accumulator initialization in createReduce

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    fca3114 View commit details
    Browse the repository at this point in the history

  40. Refactor _.min and _.max (fix jashkenas#2688)

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    8743fc0 View commit details
    Browse the repository at this point in the history

  41. Use _.find instead of _.reduce in extremum

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    bd49157 View commit details
    Browse the repository at this point in the history

  42. Revert "Enable customization of accumulator initialization in createR… 

    …educe"

This reverts commit a76ed7418a3a2d14443b7d94bdccddbfc33daf8c.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5f72f90 View commit details
    Browse the repository at this point in the history

  43. Restore the identity optimization in extremum

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    c71244a View commit details
    Browse the repository at this point in the history

  44. Put back the for loop in extremum 

    :(
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e108783 View commit details
    Browse the repository at this point in the history

  45. Inline compareNumeric in _.min and _.max 

    This doesn't seem to save any time, but surprisingly, it does save
bytes.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e2a9a83 View commit details
    Browse the repository at this point in the history

  46. Use boolean state variable, not shape-shifting callbacks in extremum 

    This saves both time and bytes.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    448d2e8 View commit details
    Browse the repository at this point in the history

  47. Don't use _.partial anymore in _.min and _.max 

    This saves function call overhead and surprisingly, also saves bytes.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5165f1f View commit details
    Browse the repository at this point in the history

  48. Enable find-by-strict-equality function elision in linearSearch 

    and use it in _.indexOf.
    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9bf9dc3 View commit details
    Browse the repository at this point in the history

  49. Use _.find instead of _.each in createReducer

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    64e62ef View commit details
    Browse the repository at this point in the history

  50. Eliminate the dir variable in createReduce

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    aaa0fcb View commit details
    Browse the repository at this point in the history

  51. Reuse the start variable in createIndexFinder

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    01f324e View commit details
    Browse the repository at this point in the history

  52. Use _.find instead of _.each in _.map

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6a0ebd8 View commit details
    Browse the repository at this point in the history

  53. Use _.find instead of _.each in internal group

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7fee0d5 View commit details
    Browse the repository at this point in the history

  54. Use _.find instead of _.each in _.filter

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f60a3ef View commit details
    Browse the repository at this point in the history

  55. Use _.times instead of linearSearch in _.chunk

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ba7df7a View commit details
    Browse the repository at this point in the history

  56. Use _.findKey instead of linearSearch in _.mapObject

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    1cb9003 View commit details
    Browse the repository at this point in the history

  57. Elide createPredicateIndexFinder

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    674ed39 View commit details
    Browse the repository at this point in the history

  58. Slim down predicate elision in linearSearch

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b7637b6 View commit details
    Browse the repository at this point in the history

  59. Move the identity optimization back to _.min and _.max

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d5b8d74 View commit details
    Browse the repository at this point in the history

  60. Inline decideNumeric in _.min and _.max

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b99a079 View commit details
    Browse the repository at this point in the history

  61. Use forward iteration in _.bindAll

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9de1ceb View commit details
    Browse the repository at this point in the history

  62. Use forward iteration in _.isEqual

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    20e88e5 View commit details
    Browse the repository at this point in the history

  63. Move the decide parameter out of the way in extremum

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d82eadc View commit details
    Browse the repository at this point in the history

  64. Generalize _.sample over the collection types

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    640332b View commit details
    Browse the repository at this point in the history

  65. Restore only the essence of former optimizeCb

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    341ad30 View commit details
    Browse the repository at this point in the history

  66. Replace bindCb by bindCb4 where appropriate

    @jgonggrijp
    jgonggrijp committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    eaba5b5 View commit details
    Browse the repository at this point in the history