fix: Allow unsigned_integer to accept any value #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Im using @leastbad 's AllFutures gem and was doing some faceted search using AllFutures. I encountered a case where I wanted the max amount for something to be 100_000_000_000 and the minimum amount to be the negative amount.
Since ActiveEntity doesnt really account for
:bigint
would it be okay to have themax_value
of an integer be::Float::INFINITY
like in the Rails bigint type?https://github.com/rails/rails/blob/83a4fa414bc9e5008825f47857fdd80e85c82033/activemodel/lib/active_model/type/big_integer.rb#L10
Error:
I can confirm monkey patching ActiveEntity locally fixes the error.