Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Caer Copyright #18

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Updating Caer Copyright #18

merged 2 commits into from
Jan 20, 2021

Conversation

MalikMAlna
Copy link

Description

  • Updating Caer Copyright from 2020 to 2021 for all instances of commented year
  • Did not update/touch upon any other copyright in project directory

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • [x ] Docstrings/Documentation updated

Related Issues

#17

Checklist:

  • [x ] I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • [x ] I have updated the documentation accordingly.
  • [x ] This PR is being made to staging and not master
  • I will squash merge this PR into staging (optional)

@jasmcaus jasmcaus changed the base branch from staging to dev January 20, 2021 07:32
@jasmcaus
Copy link
Owner

Hi @MalikMAlna, great spotting! Was too busy working on breaking issues, that it completely slipped my mind that we're in the New Year.

I see you've changed 2020 ==> 2021. Could you instead change it to 2020 ==> 2020-2021? That's a better representation, I feel.

Also, I've changed the base branch from staging to dev because that's where I add updates to Caer.

@MalikMAlna
Copy link
Author

Sounds good! Will add that update and push it in sometime before the end of today.

@MalikMAlna
Copy link
Author

There you go!

@jasmcaus jasmcaus merged commit 42cdbcc into jasmcaus:dev Jan 20, 2021
@jasmcaus
Copy link
Owner

Thanks for your patch, @MalikMAlna! I've added you as a contributor to this repo. Feel free to open a PR at any time if you have any more contributions. Cheers :)

jasmcaus added a commit that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants