Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7 macro names #9

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Conversation

stefano-p
Copy link
Contributor

Hi @jasmcaus, I've made the changes as per Issue #7. Documentation has been updated accordingly. Internal unit tests are successfull. To me it seems all okay.

@stefano-p stefano-p requested a review from jasmcaus as a code owner July 13, 2021 18:40
Copy link
Owner

@jasmcaus jasmcaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @stefano-p!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants