Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatible with php 8 #149

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

aldinokemal
Copy link
Contributor

@aldinokemal aldinokemal commented Jul 28, 2023

Context:

  • Add compatibility with PHP 8 (tested in PHP 8.2)
  • Support backward compatibility (both PHP 7 and 8)

Notes:

  • I have tested in my locally running PHP 8 and 7.4 together, and there's no issue

@jasny
Copy link
Owner

jasny commented Jul 29, 2023

Thanks.

Please just update the Cookies class and modify the minimum PHP version in composer.json. I'll do a minor version release (v0.5) afterward. People on PHP7 can continue to use 0.4.

Please also update .scrutinizer.yml, so scrutinize analysis will succeed (probably just need to set the PHP version).

@aldinokemal
Copy link
Contributor Author

I have updated the PR. when do you plan to upgrade this repository to support PHP 8?
@jasny

@jasny
Copy link
Owner

jasny commented Aug 3, 2023

Will this change not work with PHP 8.0 and 8.1?

@aldinokemal
Copy link
Contributor Author

@jasny both can use the old version I believe, should we change become 8.0 as well?

@jasny
Copy link
Owner

jasny commented Aug 5, 2023

Yes, please set the minimum version to 8.0.

@jasny jasny force-pushed the feat/compatible-php-8 branch 2 times, most recently from b51babb to f25a907 Compare August 9, 2023 12:42
@jasny jasny merged commit ef9f917 into jasny:master Aug 9, 2023
3 checks passed
@aldinokemal aldinokemal deleted the feat/compatible-php-8 branch August 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants