Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow undefined for useHydrate #164

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

jason89521
Copy link
Owner

Proposed change

close #146

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Testing
  • Refactor
  • Chore (tool changes, configuration changes, and changes to things that do not actually go into production at all)

Implementation

Related Issue

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #164 (6379b41) into main (328e697) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   97.83%   97.83%   -0.01%     
==========================================
  Files          31       31              
  Lines        1941     1940       -1     
  Branches      293      294       +1     
==========================================
- Hits         1899     1898       -1     
  Misses         42       42              
Impacted Files Coverage Δ
src/lib/hooks/useHydrate.ts 100.00% <100.00%> (ø)
src/lib/model/Model.ts 98.25% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jason89521 jason89521 merged commit e7b15e7 into main Jul 15, 2023
4 checks passed
@jason89521 jason89521 deleted the feat/useHydrate-accept-undefined branch July 15, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useHydrate should also handle undefined
1 participant