Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to augment joi 17 module #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TCMiranda
Copy link

No description provided.

@jasonaibrahim
Copy link
Owner

I do see the intellisense, but there are typescript errors preventing compilation

@TCMiranda
Copy link
Author

I see. What about tweaking the Joi types to be compatible with those changes?
I think that if we update the types to export the interfaces on the Joi package it would work

@jasonaibrahim
Copy link
Owner

I incorporated your index.ts file directly into a project that uses sideway/joi and everything works as expected. The remaining challenge here is going to be the distribution, because running tsc produces hundreds of errors. I will attempt to produce a distribution that allows for import and report back

@TCMiranda
Copy link
Author

TCMiranda commented Nov 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants