Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or remove title element ID #7

Closed
jasonaowen opened this issue Feb 23, 2017 · 0 comments
Closed

Fix or remove title element ID #7

jasonaowen opened this issue Feb 23, 2017 · 0 comments

Comments

@jasonaowen
Copy link
Owner

The <div> tag that contains the text "Who is this?" includes an id attribute. Unfortunately, it is always set to the value undefined-title, because the code that fills it out is looking at the wrong property!

Is the id attribute even necessary? I added it as I was learning React. Either fix it or remove it.
botwhytho added a commit to botwhytho/recurse-faces that referenced this issue Feb 27, 2017
@botwhytho
Fixed Issue jasonaowen#7
d6a4a32
@botwhytho botwhytho mentioned this issue Feb 27, 2017
Merged
botwhytho added a commit to botwhytho/recurse-faces that referenced this issue Feb 28, 2017
@botwhytho
use correct person attribute for div id
863d759 
Issue jasonaowen#7  Fix or remove title element ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonaowen