Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TravisCI integration #56

Merged
merged 1 commit into from
May 3, 2019
Merged

Add TravisCI integration #56

merged 1 commit into from
May 3, 2019

Conversation

johnpaulashenfelter
Copy link
Collaborator

@johnpaulashenfelter johnpaulashenfelter commented May 3, 2019 •
edited
Loading

Add bare-minimum TravisCI setup

Closes: #35

jasonaowen
jasonaowen requested changes May 3, 2019
View reviewed changes
Copy link
Owner

@jasonaowen jasonaowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, it's great how much Travis autoconfigures based on the language!

Did Travis run this for you? I don't see it in my dashboard, and I can't find it on yours (maybe I just don't have permission).

.nvmrc Outdated
@@ -0,0 +1 @@
10.15.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to set this to lts/dubnium, so that we get the latest point releases. See long-term support in the NVM docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask what you wanted to lock it to. I think you might want to lock it so you're not surprised when CI suddenly is using a new version 😄 but easy to see if it works

@johnpaulashenfelter johnpaulashenfelter self-assigned this May 3, 2019
jasonaowen
jasonaowen approved these changes May 3, 2019
View reviewed changes
Copy link
Owner

@jasonaowen jasonaowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just talked in person! @johnpaulashenfelter will update to Xenial instead of the default Trusty, add ending newlines to the files, and squash the commits.

Thank you, @johnpaulashenfelter ! 💜

@jasonaowen jasonaowen merged commit 155cf5c into jasonaowen:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonaowen jasonaowen jasonaowen approved these changes

Assignees

@johnpaulashenfelter johnpaulashenfelter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up CI
2 participants
@johnpaulashenfelter @jasonaowen